Feature quick select #2860
Merged
Feature quick select #2860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are two automatic checks that failed: Build and Prettify. Build uses javac as a compiler in build.yml, while my colleague and I compiled using Maven. I am pretty sure that this is the reason for the failure. How should we proceed on this? We could change build.yml accordingly, if this is an option for you. Also, Prettify failed and it is not quite obvious to me why. Do you maybe have an idea what the reason could be? |
|
The prettier is just faulty, nvm |
|
I've changed builds to maven, the verify command used should run your tests, right? |
During our work, we used the test command, but verify also seems to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
References
Wikipedia Entry
Checklist: