Skip to content

My Commit for the Issue #2864 Pascal's Triangle #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 13, 2021
Merged

My Commit for the Issue #2864 Pascal's Triangle #2871

merged 9 commits into from
Dec 13, 2021

Conversation

hs094
Copy link
Contributor

@hs094 hs094 commented Dec 10, 2021 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@hs094
Copy link
Contributor Author

hs094 commented Dec 10, 2021

Made my PR. Please Review and Respond.

siriak
siriak requested changes Dec 11, 2021
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a small comment about automated tests, everything else looks good!

siriak
siriak previously approved these changes Dec 12, 2021
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing because of a typo in the last test at com.thealgorithms.maths.ArrayLeftRotationTest.testForEight(PascalTriangleTest.java:38). Please fix it, everything else is solid, thanks!

@hs094
Copy link
Contributor Author

hs094 commented Dec 12, 2021

I have resolved all Checks please Merge my PR.

siriak
siriak approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@siriak siriak merged commit b1242e0 into TheAlgorithms:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hs094 @siriak