Skip to content

Added KaprekarNumbersTest #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2021
Merged

Added KaprekarNumbersTest #2881

merged 2 commits into from
Dec 15, 2021

Conversation

s-devran
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@siriak siriak merged commit 98656cb into TheAlgorithms:master Dec 15, 2021
subhroacharjee
subhroacharjee reviewed Jan 2, 2022
View reviewed changes
Copy link
Contributor

@subhroacharjee subhroacharjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes that I think will make this one better

src/main/java/com/thealgorithms/maths/KaprekarNumbers.java
// Checks whether a given number is Kaprekar Number or not

public static boolean isKaprekarNumber(long number) {
long numberSquared = number * number;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use BigInteger here which will make this better.

src/main/java/com/thealgorithms/maths/KaprekarNumbers.java
@@ -0,0 +1,27 @@
package com.thealgorithms.maths;

public class KaprekarNumbers {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add a function which will generate all the Kaprekar Numbers in a given range

@subhroacharjee subhroacharjee mentioned this pull request Jan 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subhroacharjee subhroacharjee subhroacharjee left review comments

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-devran @siriak @subhroacharjee