Skip to content

added java code of babylonian method #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2022
Merged

added java code of babylonian method #2883

merged 3 commits into from
Jan 30, 2022

Conversation

SaumyaBhushan
Copy link
Contributor

@SaumyaBhushan SaumyaBhushan commented Dec 23, 2021 •
edited
Loading

Describe your change:

  • Add an algorithm

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

siriak
siriak requested changes Dec 24, 2021
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace main() with tests as in https://github.com/TheAlgorithms/Java/blob/98656cb0cdacd175559272bcbb8bc3b86ddac52a/src/test/java/com/thealgorithms/maths/KaprekarNumbersTest.java, everything else looks good, thanks!

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 24, 2022
@SaumyaBhushan
Copy link
Contributor Author

replaced main() with test.

@22aam
Copy link

22aam commented Jan 24, 2022

can you tell me about this pull request

@github-actions github-actions bot removed the stale label Jan 25, 2022
@SaumyaBhushan
Copy link
Contributor Author

can you tell me about this pull request

Babylonian method is an iterative method to find the square root of a number. This is also sometimes called as Hero's method

siriak
siriak approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@siriak siriak merged commit 101d08a into TheAlgorithms:master Jan 30, 2022
@SaumyaBhushan SaumyaBhushan deleted the math-code-branch branch January 31, 2022 04:24
@22aam 22aam mentioned this pull request Jan 31, 2022
Closed
22aam added a commit to 22aam/Java that referenced this pull request Jan 31, 2022
@22aam
Revert "Add Square Root by Babylonian Method (TheAlgorithms#2883)"
d3d2308 
This reverts commit 101d08a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@22aam 22aam 22aam approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SaumyaBhushan @22aam @siriak