Skip to content

CountFriendsPairing Algorithm Added #2889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

CountFriendsPairing Algorithm Added #2889

wants to merge 6 commits into from

Conversation

Deeeeksha
Copy link

Describe your change:

  • Algorithm added in Dynamic Programming.

  • Test Cases of the algorithm also Added.

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Deeeeksha
Copy link
Author

Hi @siriak . Is there any update on the issue? Kindly review the changes .

@Deeeeksha
Copy link
Author

Hello @siriak and @yanglbme . Is there any update on the issue part ?? Kindly review the changes Please.

siriak
siriak requested changes Jan 16, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for the response time, was pretty busy. Could you add automated tests with the @test thing? There are examples in the codebase. Also please add indentation where appropriate. Thanks!

@zhrgithub
Copy link

zhrgithub commented Jan 17, 2022 via email

@Deeeeksha
Copy link
Author

Thankyou @siriak . I will make changes as requested

@zhrgithub
Copy link

zhrgithub commented Jan 18, 2022 via email

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 18, 2022
@zhrgithub
Copy link

zhrgithub commented Feb 18, 2022 via email

@github-actions github-actions bot removed the stale label Feb 19, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 22, 2022
@siddhant2002
Copy link
Contributor

@siriak please check the pr

@github-actions github-actions bot removed the stale label Mar 27, 2022
siriak
siriak requested changes Mar 28, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My latest review comments were not addressed. Proper indentation and automated tests need to be added

@siddhant2002
Copy link
Contributor

@siriak I've added the test and indentation

@siriak
Copy link
Member

siriak commented Mar 31, 2022

image
I don't see your changes, have you done them in this branch?

@siddhant2002
Copy link
Contributor

@siriak I've created my own file where I've added the code and test cases. Please do check @ https://github.com/siddhant2002/Java/blob/master/src/main/java/com/thealgorithms/dynamicprogramming/CountFriendsPairing.java and https://github.com/siddhant2002/Java/blob/master/src/test/java/com/thealgorithms/others/CountFriendsPairingTest.java

@siriak
Copy link
Member

siriak commented Apr 2, 2022

The code looks good, could you make a PR with your changes?

@siriak siriak closed this in 060069c Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak requested changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Deeeeksha @zhrgithub @siddhant2002 @siriak