Add Sorting algorithm QuickSortMedianOfThree #294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
christianbender
requested changes
Apr 2, 2018
| private void medianOfThree(int[] array, int leftIndex, int rightIndex){ | ||
|
|
||
| int shortter = leftIndex; | ||
| int mid = leftIndex + (rightIndex - leftIndex) / 2; |
There was a problem hiding this comment.
Write instead int mid = (rightIndex + leftIndex) / 2;. Because simpler!
| } | ||
|
|
||
| private void changePivot(int[] array, int leftIndex, int rightIndex) { | ||
| int pivotIndex = leftIndex + (rightIndex - leftIndex) / 2; |
There was a problem hiding this comment.
Write instead int pivotIndex = (rightIndex + leftIndex) / 2;. Because simpler.
| } | ||
|
|
||
| private void swap(int[] array, int i, int j) { | ||
| if(array == null) |
There was a problem hiding this comment.
- Use curly braces.
- This exception handling you can write to the methods above, too.
| int leftIndex = 0; | ||
| int rightIdex = array.length - 1; | ||
|
|
||
| QuickSortMedianOfThree quick = new QuickSortMedianOfThree(); |
There was a problem hiding this comment.
If you write the methods above as static you can use the methods right on.
| } | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Put in some comments in your code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.