Fixes(#2884) #2955
Merged
Fixes(#2884) #2955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriak
requested changes
Feb 22, 2022
src/main/java/com/thealgorithms/dynamicprogramming/NewManShanksPrime.java
Outdated
Show resolved
Hide resolved
|
@siriak please check the updated pr |
siriak
requested changes
Feb 25, 2022
src/test/java/com/thealgorithms/others/NewManShanksPrimeTest.java
Outdated
Show resolved
Hide resolved
|
Ok
| |
张泓锐
|
|
***@***.***
|
签名由网易邮箱大师定制
在2022年02月25日 20:41，Andrii ***@***.***> 写道：
@siriak requested changes on this pull request.
In src/test/java/com/thealgorithms/others/NewManShanksPrimeTest.java:
@@ -0,0 +1,54 @@
+package com.thealgorithms.others;
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.*;
+
+import com.thealgorithms.dynamicprogramming.NewManShanksPrime;
+public class NewManShanksPrimeTest {
+ @test
+ void testOne()
+ {
+ System.out.println((NewManShanksPrime.nthManShanksPrime(1)));
Please add assertions to your tests. The tests must validate that the calculated number is what we expect for the corresponding input.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
@siriak , I've made the necessary changes please check |
|
thank you my brother!
| |
zhr
|
|
***@***.***
|
签名由网易邮箱大师定制
在2022年02月25日 22:27，Siddhant Swarup ***@***.***> 写道：
@siriak , I've made the necessary changes please check
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
References
Checklist:
Fixes: #{$ISSUE_NO}.