Skip to content

Fixes: #2836 #2974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2022
Merged

Fixes: #2836 #2974

merged 3 commits into from
Mar 12, 2022

Conversation

nikslyon19
Copy link
Contributor

Describe your change:

  • Fix a bug or typo in an existing algorithm?

References

Issue No. #2836

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@nikslyon19 nikslyon19 changed the title Fixes: #2836 Fixes for FloodFill Algorithm (#2836) Mar 9, 2022
@nikslyon19 nikslyon19 changed the title Fixes for FloodFill Algorithm (#2836) Fixes: #2836 Mar 9, 2022
siriak
siriak requested changes Mar 10, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a couple of naming suggestions, and the PR is good to go!

siriak
siriak reviewed Mar 11, 2022
View reviewed changes
siriak
siriak reviewed Mar 11, 2022
View reviewed changes
siriak
siriak approved these changes Mar 12, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@siriak siriak merged commit 260a302 into TheAlgorithms:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikslyon19 @siriak