Skip to content

Refactored some files to remove code smells. #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 21, 2022

Conversation

Rushipatel0995
Copy link
Contributor

Describe your change:

  • Refactored some files for the algorithms. Since this is a refactoring change I have merged the refactoring for Hill Cipher, SinglyLinkedList and DoublyLinkedList.
  • Removed duplicate codes by extracting method, renamed variables for better understandability, pulled up variables/methods for better consistency, extracted class to remove feature envy smell and moved method for the same functionality classes. If the pull request is accepted I am looking forward to refactor this entire project since I found multiple smells on SonarQube as well as in DesigniteJava.

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Rushi added 3 commits March 17, 2022 16:02
…d variable, extracted method to reduce duplicate code, moved method to maintain consistent code with respect to the functionality, pulled up variables and methods and extracted class as part of refactoring.
…d variables, extracted method to reduce duplicate code, moved method to maintain consistent code with respect to the functionality, pulled up variables and methods and extracted class as part of refactoring.
@siriak siriak merged commit 1d5d672 into TheAlgorithms:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants