Skip to content

Modified methods #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 3, 2022
Merged

Modified methods #2988

merged 6 commits into from
Apr 3, 2022

Conversation

funCodeSonali
Copy link
Contributor

@funCodeSonali funCodeSonali commented Mar 23, 2022 •
edited
Loading

SinglyLinkedList.java

https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/datastructures/lists/SinglyLinkedList.java
/**

My Changes

  • Fixed bugs in swapNodes() , reverseList() methods
  • Modified deleteDuplicates() , detectLoop() methods to easier code
  • Shifted methods from Node Class to SinglyLinkedList Class

References

#2938 (comment)

siriak
siriak previously approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, could you fix the build?

siriak
siriak approved these changes Apr 3, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@siriak siriak merged commit 77bcd4d into TheAlgorithms:master Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@funCodeSonali @siriak