Skip to content

Code refactor for AbsoluteValue improvements #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Code refactor for AbsoluteValue improvements #3018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
510ac99
feat: Code refactor for AbsoluteValue improvements
cristbjesus Apr 19, 2022
b320f54
Merge branch 'master' into feature/maths-absolutevalue-code-improvements
yanglbme Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions src/main/java/com/thealgorithms/maths/AbsoluteValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,14 @@
package com.thealgorithms.maths;

import java.util.Random;

public class AbsoluteValue {

public static void main(String[] args) {
Random random = new Random();

/* test 1000 random numbers */
for (int i = 1; i <= 1000; ++i) {
int randomNumber = random.nextInt();
assert absVal(randomNumber) == Math.abs(randomNumber);
}
}

/**
* If value is less than zero, make value positive.
* Returns the absolute value of a number.
*
* @param value a number
* @return the absolute value of a number
* @param number The number to be transformed
* @return The absolute value of the {@code number}
*/
public static int absVal(int value) {
return value < 0 ? -value : value;
public static int getAbsValue(int number) {
return number < 0 ? -number : number;
}
}
18 changes: 18 additions & 0 deletions src/test/java/com/thealgorithms/maths/AbsoluteValueTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package com.thealgorithms.maths;

import org.junit.jupiter.api.Test;

import java.util.concurrent.ThreadLocalRandom;
import java.util.stream.Stream;

import static org.junit.jupiter.api.Assertions.assertEquals;

public class AbsoluteValueTest {

@Test
void testGetAbsValue() {
Stream.generate(() -> ThreadLocalRandom.current().nextInt())
.limit(1000)
.forEach(number -> assertEquals(Math.abs(number), AbsoluteValue.getAbsValue(number)));
}
}