Skip to content

Code refactor for AbsoluteMin improvements #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Code refactor for AbsoluteMin improvements #3022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: Code refactor for AbsoluteMin improvements 
I'm refactoring some classes from the `maths` package to have a cleaner,
more concise, easier to maintain and better documented code.

I've also updated the code to use features from newer versions of Java
and I've created some unit tests because it was missing unit tests for
AbsoluteMin (I'm using now unit tests instead of main method to test the
feature).

Resolves: #3021
  • Loading branch information
@cristbjesus
cristbjesus committed Apr 19, 2022
commit 651992cfd65b2c835bf04e451610b092ed7ec05e
44 changes: 20 additions & 24 deletions src/main/java/com/thealgorithms/maths/AbsoluteMin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,35 +2,31 @@

import java.util.Arrays;

/**
* description:
*
* <p>
* absMin([0, 5, 1, 11]) = 0, absMin([3 , -10, -2]) = -2
*/
public class AbsoluteMin {

public static void main(String[] args) {
int[] testnums = {4, 0, 16};
assert absMin(testnums) == 0;

int[] numbers = {3, -10, -2};
System.out.println("absMin(" + Arrays.toString(numbers) + ") = " + absMin(numbers));
}

/**
* get the value, returns the absolute min value min
* Compares the numbers given as arguments to get the absolute min value.
*
* @param numbers contains elements
* @return the absolute min value
* @param numbers The numbers to compare
* @return The absolute min value
*/
public static int absMin(int[] numbers) {
int absMinValue = numbers[0];
for (int i = 1, length = numbers.length; i < length; ++i) {
if (Math.abs(numbers[i]) < Math.abs(absMinValue)) {
absMinValue = numbers[i];
}
public static int getMinValue(int... numbers) {
if (numbers.length == 0) {
throw new IllegalArgumentException("Numbers array cannot be empty");
}
return absMinValue;

var absMinWrapper = new Object() {
int value = numbers[0];
};

Arrays.stream(numbers)
.skip(1)
.forEach(number -> {
if (Math.abs(number) < Math.abs(absMinWrapper.value)) {
absMinWrapper.value = number;
}
});

return absMinWrapper.value;
}
}
21 changes: 21 additions & 0 deletions src/test/java/com/thealgorithms/maths/AbsoluteMinTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package com.thealgorithms.maths;

import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;

public class AbsoluteMinTest {

@Test
void testGetMinValue() {
assertEquals(0, AbsoluteMin.getMinValue(4, 0, 16));
assertEquals(-2, AbsoluteMin.getMinValue(3, -10, -2));
}

@Test
void testGetMinValueWithNoArguments() {
Exception exception = assertThrows(IllegalArgumentException.class, () -> AbsoluteMin.getMinValue());
assertEquals("Numbers array cannot be empty", exception.getMessage());
}
}