Skip to content

Code refactor for AliquotSum improvements #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2022
Merged

Code refactor for AliquotSum improvements #3027

merged 1 commit into from
Apr 21, 2022

Conversation

cristbjesus
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

See: #3026

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All functions and variable names follow Java naming conventions.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cristbjesus
feat: Code refactor for AliquotSum improvements
f4b7047 
I'm refactoring some classes from the `maths` package to have a cleaner,
more concise, easier to maintain and better documented code.

I've also updated the code to use features from newer versions of Java
and I've created some unit tests because it was missing unit tests for
AliquotSum (I'm using now unit tests instead of main method to test the
feature).

Resolves: TheAlgorithms#3026
@cristbjesus cristbjesus changed the title feat: Code refactor for AliquotSum improvements Code refactor for AliquotSum improvements Apr 20, 2022
@yanglbme yanglbme merged commit 9f7613b into TheAlgorithms:master Apr 21, 2022
@cristbjesus cristbjesus deleted the feature/maths-aliquotsum-code-improvements branch April 21, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanglbme yanglbme yanglbme approved these changes

@siriak siriak Awaiting requested review from siriak siriak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristbjesus @yanglbme