Skip to content

Code refactor for AbsoluteMax improvements 2 #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2022
Merged

Code refactor for AbsoluteMax improvements 2 #3029

merged 2 commits into from
Apr 21, 2022

Conversation

cristbjesus
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

See: #3028

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All functions and variable names follow Java naming conventions.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cristbjesus
feat: Code refactor for AbsoluteMax improvements
6f2b923 
I'm refactoring some classes from the `maths` package to have a cleaner,
more concise, easier to maintain and better documented code.

I've refactored the AbsoluteMax again because I realized it can be
improved even further by replacing the `if` inside `forEach` with a
`filter` in the Stream.

Resolves: TheAlgorithms#3028
@cristbjesus cristbjesus changed the title Code refactor for AbsoluteMax improvements Code refactor for AbsoluteMax improvements 2 Apr 20, 2022
@yanglbme yanglbme merged commit c8b0a20 into TheAlgorithms:master Apr 21, 2022
@cristbjesus cristbjesus deleted the feature/maths-absolutemax-code-improvements-2 branch April 21, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanglbme yanglbme yanglbme approved these changes

@siriak siriak Awaiting requested review from siriak siriak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristbjesus @yanglbme