Skip to content

Wigglesort #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 25, 2022
Merged

Wigglesort #3032

merged 5 commits into from
Apr 25, 2022
+157 −0

Conversation

BranAndSceolan
Copy link
Contributor

@BranAndSceolan BranAndSceolan commented Apr 21, 2022 •
edited
Loading

Describe your change:

Fixes: #3023

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
PHP-Proxy

PHP-Proxy

Error accessing resource: 404 - Not Found

siriak
siriak requested changes Apr 23, 2022
View reviewed changes
@BranAndSceolan
Copy link
Contributor Author

Thank you for reviewing, I have made the changes you requested.

@BranAndSceolan
remove off by-one-error for odd arrays,
a696d76 
add link explaining the error and further discussion
siriak
siriak approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@siriak siriak merged commit 99ff516 into TheAlgorithms:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak

@yanglbme yanglbme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add wiggleSort
2 participants
@BranAndSceolan @siriak