Skip to content

[TEST] Add tests for GCD algorithm based on MC/DC standard and PrimeCheck algorithm based on All-DU-Paths standard #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 25, 2022
Merged

[TEST] Add tests for GCD algorithm based on MC/DC standard and PrimeCheck algorithm based on All-DU-Paths standard #3062

merged 3 commits into from
May 25, 2022

Conversation

anhpham197
Copy link
Contributor

@anhpham197 anhpham197 commented May 23, 2022 •
edited
Loading

Describe your change:

  • Add test for function gcd (int num1, int num2) in GCD algorithm based on MC/DC standard.
  • Add test for function isPrime (int n) in PrimeCheck algorithm based on All-DU-Paths standard.

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@anhpham197 anhpham197 changed the title [TEST] Add tests for GCD algorithm based on MC/DC standard [TEST] Add tests for GCD algorithm based on MC/DC standard and PrimeCheck algorithm based on All-DU-Paths standard May 23, 2022
@anhpham197
Copy link
Contributor Author

Here is my report:
GCDTest and PrimeCheckTest report.pdf

siriak
siriak approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit f35eef2 into TheAlgorithms:master May 25, 2022
Jtmonument pushed a commit to Jtmonument/Java that referenced this pull request Jun 9, 2022
@anhpham197 @Jtmonument
Add tests for GCD and PrimeCheck (TheAlgorithms#3062)
a235a81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anhpham197 @siriak