Skip to content

add Test for SelectionSort #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 19, 2022
Merged

add Test for SelectionSort #3091

merged 10 commits into from
Jul 19, 2022

Conversation

hnq-jan8
Copy link
Contributor

@hnq-jan8 hnq-jan8 commented Jun 1, 2022 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@hnq-jan8 hnq-jan8 requested review from siriak and yanglbme as code owners June 1, 2022 17:15
@hnq-jan8 hnq-jan8 changed the title add Test for SumOfDigits add Junit Test for SumOfDigits Jun 2, 2022
@hnq-jan8 hnq-jan8 changed the title add Junit Test for SumOfDigits add Junit Test for SumOfDigits and SelectionSort Jun 2, 2022
@hnq-jan8 hnq-jan8 changed the title add Junit Test for SumOfDigits and SelectionSort add JUnit Test for SumOfDigits and SelectionSort: Jun 2, 2022
@hnq-jan8 hnq-jan8 changed the title add JUnit Test for SumOfDigits and SelectionSort: add JUnit Test for SumOfDigits and SelectionSort Jun 2, 2022
@hnq-jan8 hnq-jan8 changed the title add JUnit Test for SumOfDigits and SelectionSort add JUnit Test for SelectionSort Jun 9, 2022
@hnq-jan8 hnq-jan8 changed the title add JUnit Test for SelectionSort add JUnit Test for SumOfDigits and SelectionSort Jun 9, 2022
@hnq-jan8 hnq-jan8 changed the title add JUnit Test for SumOfDigits and SelectionSort add JUnit Test for SelectionSort Jun 9, 2022
@hnq-jan8 hnq-jan8 changed the title add JUnit Test for SelectionSort add Test for SelectionSort Jun 9, 2022
siriak
siriak requested changes Jun 16, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests look good, but please revert unrelated changes to SumOfDigitsTest

@hnq-jan8 hnq-jan8 requested a review from siriak June 17, 2022 11:00
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 19, 2022
siriak
siriak approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@siriak siriak merged commit 898c2f6 into TheAlgorithms:master Jul 19, 2022
@hnq-jan8 hnq-jan8 deleted the test branch July 20, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hnq-jan8 @siriak