Skip to content

Add test function for Armstrong #3104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2022
Merged

Add test function for Armstrong #3104

merged 2 commits into from
Jun 8, 2022

Conversation

huyhq38
Copy link
Contributor

@huyhq38 huyhq38 commented Jun 2, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@huyhq38 huyhq38 requested review from siriak and yanglbme as code owners June 2, 2022 06:27
siriak
siriak approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 77e4813 into TheAlgorithms:master Jun 8, 2022
Jtmonument pushed a commit to Jtmonument/Java that referenced this pull request Jun 9, 2022
@huyhq38 @siriak @Jtmonument
Add test for Armstrong (TheAlgorithms#3104)
0ca4a32 
Co-authored-by: Andrii Siriak <siryaka@gmail.com>
Boiarshinov pushed a commit to Boiarshinov/Java that referenced this pull request Jun 20, 2022
@huyhq38 @siriak @Boiarshinov
Add test for Armstrong (TheAlgorithms#3104)
e9ab349 
Co-authored-by: Andrii Siriak <siryaka@gmail.com>
Boiarshinov pushed a commit to Boiarshinov/Java that referenced this pull request Jun 20, 2022
@huyhq38 @siriak @Boiarshinov
Add test for Armstrong (TheAlgorithms#3104)
9641592 
Co-authored-by: Andrii Siriak <siryaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huyhq38 @siriak