Skip to content

Add Hexadecimal to Octal #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 6, 2017
Merged

Add Hexadecimal to Octal #316

merged 4 commits into from
Dec 6, 2017

Conversation

The-TJ
Copy link
Contributor

@The-TJ The-TJ commented Nov 17, 2017 •
edited
Loading

Program that converts Hexadecimal numbers to Octal.

@The-TJ
Create HextoDec.java
37838f6 
Program that converts Hexadecimal numbers to decimal.
@The-TJ The-TJ changed the title Create HextoDec.java Added Hexadecimal to Decimal Nov 18, 2017
varunu28
varunu28 suggested changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@varunu28 varunu28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Enter comments for your function to give description of what the function is actually doing and what are the parameters and return value

@The-TJ The-TJ changed the title Added Hexadecimal to Decimal Add Hexadecimal to Octal Nov 22, 2017
@The-TJ
Copy link
Contributor Author

The-TJ commented Nov 22, 2017

The comments have been added. Thanks for reviewing the code!

varunu28
varunu28 suggested changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@varunu28 varunu28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Keep the main method for input and the final output
  • Create another function for Octal conversion
  • Add proper conventions for comments. Refer InsertionSort under sorts for conventions

@The-TJ
Copy link
Contributor Author

The-TJ commented Nov 26, 2017

All the changes have been made. Please check the code now. Thank you very much for your time!

@The-TJ
Copy link
Contributor Author

The-TJ commented Dec 6, 2017

Hey Varunu. Do need to make any other changes or this is grand as it is?

@varunu28 varunu28 merged commit 6efaddb into TheAlgorithms:master Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunu28 varunu28 varunu28 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@The-TJ @varunu28