Skip to content

Create a new Rabin-Karp Algorithm #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 5, 2022
Merged

Create a new Rabin-Karp Algorithm #3201

merged 6 commits into from
Aug 5, 2022

Conversation

tackhwa
Copy link
Contributor

@tackhwa tackhwa commented Jul 30, 2022 •
edited
Loading

This is a Rabin-Karp Algorithm for Pattern Searching

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Rabin–Karp algorithm

Checklist:

  • I have read CONTRIBUTING.md.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.

@tackhwa
Create a new Rabin-Karp Algorithm
cfdb8c5 
This is a Rabin-Karp Algorithm for Pattern Searching
@tackhwa tackhwa requested review from siriak and yanglbme as code owners July 30, 2022 16:43
siriak
siriak requested changes Jul 31, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, could you just replace main() with a couple of JUnit tests and add the .java extension to the file? See examples of tests in src/test/

@tackhwa
Copy link
Contributor Author

tackhwa commented Aug 3, 2022

The code looks good, could you just replace main() with a couple of JUnit tests and add the .java extension to the file? See examples of tests in src/test/

I have already added the JUnit test case and '.java' extension, please take your time to review, Thank You.

@tackhwa tackhwa requested a review from siriak August 3, 2022 18:09
siriak
siriak requested changes Aug 4, 2022
View reviewed changes
@tackhwa tackhwa requested a review from siriak August 4, 2022 16:48
@tackhwa
Copy link
Contributor Author

tackhwa commented Aug 5, 2022

I have already resolved the issue, please take your time to review it, thank you.

siriak
siriak approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 92bd9ba into TheAlgorithms:master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tackhwa @siriak