Skip to content

Closes #3274 Add BubbleSort unit tests #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 19, 2022
Merged

Closes #3274 Add BubbleSort unit tests #3275

merged 3 commits into from
Sep 19, 2022

Conversation

aitorfi
Copy link
Contributor

@aitorfi aitorfi commented Sep 16, 2022

Describe your change:

Added unit tests for the BubbleSort algorithm and removed assert statements from the algorithm class.

References

Closes #3274

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

siriak
siriak requested changes Sep 18, 2022
View reviewed changes
@aitorfi aitorfi requested a review from siriak September 19, 2022 16:17
siriak
siriak approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) September 19, 2022 17:22
@siriak siriak merged commit a2dd154 into TheAlgorithms:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add BubbleSort unit tests
2 participants
@aitorfi @siriak