Skip to content

Constructors BigInteger and BigDecimal used to wrap primitives should never be used. #3627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2022
Merged

Constructors BigInteger and BigDecimal used to wrap primitives should never be used. #3627

merged 3 commits into from
Nov 6, 2022

Conversation

kongleong86
Copy link
Contributor

Constructors BigInteger and BigDecimal used to wrap primitives should never be used.
Doing so is less clear and uses more memory than simply using the desired value in the case of strings, and using valueOf for everything else.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

kongleong86 and others added 2 commits October 26, 2022 18:44
@kongleong86
Merge branch 'master' into feature2
656cd2b 
# Conflicts:
#	src/main/java/com/thealgorithms/ciphers/RSA.java
Merge branch 'master' into feature2
2ee615b
@debasishbsws debasishbsws self-requested a review as a code owner November 6, 2022 12:06
debasishbsws
debasishbsws approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@debasishbsws debasishbsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good nothing should be broke

@debasishbsws debasishbsws merged commit c8ecd23 into TheAlgorithms:master Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debasishbsws debasishbsws debasishbsws approved these changes

@siriak siriak Awaiting requested review from siriak siriak is a code owner

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kongleong86 @debasishbsws