Skip to content

Improving priority queues with max-heap #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 13, 2022
Merged

Improving priority queues with max-heap #3648

merged 10 commits into from
Dec 13, 2022

Conversation

puneetripathi
Copy link
Contributor

Improving time complexity of Priority Queues with help of Max-heap. Insertion time complexity, O(N) -> O(log(N))

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@puneetripathi
Improving priority queues with max-heap
993e16e 
Improving time complexity of Priority Queues with help of Max-heap.
Insertion time complexity, O(N) -> O(log(N))
debasishbsws
debasishbsws requested changes Nov 16, 2022
View reviewed changes
puneetripathi and others added 2 commits November 16, 2022 18:31
@puneetripathi
Update src/main/java/com/thealgorithms/datastructures/queues/Priority…
eefe56a 
…Queues.java

Co-authored-by: Debasish Biswas <debasishbsws.abc@gmail.com>
@puneetripathi
Update src/main/java/com/thealgorithms/datastructures/queues/Priority…
f20006a 
…Queues.java

Co-authored-by: Debasish Biswas <debasishbsws.abc@gmail.com>
@debasishbsws
Copy link
Member

Please add some JUnit Tests for this code
https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms/datastructures
You can refer to this

siriak
siriak requested changes Nov 17, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add some JUnit tests (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)

@puneetripathi
Copy link
Contributor Author

Sorry, I wasn't able to see your messages @siriak and @debasishbsws. I had my semester practical examination going on, so didn't have much time left off after studying. Sorry for the late reply.
I have added JUnit testing as per your wish inside the test folder, JUnit testing PR is #3778

@puneetripathi puneetripathi requested review from siriak and debasishbsws and removed request for debasishbsws and siriak November 26, 2022 19:11
@puneetripathi puneetripathi requested review from debasishbsws and removed request for siriak November 26, 2022 19:12
@puneetripathi
Copy link
Contributor Author

Sorry for the request spams, didnt know you cannot ask two people to review at same time

debasishbsws
debasishbsws previously approved these changes Nov 27, 2022
View reviewed changes
debasishbsws
debasishbsws reviewed Nov 27, 2022
View reviewed changes
Copy link
Member

@debasishbsws debasishbsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the build fail.

@debasishbsws
Copy link
Member

@siriak review. Test-case is already merge through #3778

@debasishbsws debasishbsws requested a review from siriak November 27, 2022 12:11
debasishbsws
debasishbsws previously approved these changes Nov 27, 2022
View reviewed changes
@debasishbsws debasishbsws enabled auto-merge (squash) November 27, 2022 12:12
@puneetripathi
Copy link
Contributor Author

@siriak please approve the changes, been waiting for 6 days

@puneetripathi
Copy link
Contributor Author

@yanglbme @siriak approval is still pending!

@puneetripathi puneetripathi requested review from debasishbsws and siriak and removed request for siriak and debasishbsws December 12, 2022 16:57
@puneetripathi
Copy link
Contributor Author

@siriak @yanglbme this is ridiculous, I don't understand why you guys still haven't approved the changes. Did I do something wrong, if not why is it taking so long?

@yanglbme yanglbme disabled auto-merge December 13, 2022 08:11
@yanglbme yanglbme enabled auto-merge (squash) December 13, 2022 08:12
@yanglbme
Copy link
Member

@siriak please review the change

@yanglbme yanglbme merged commit 5512fea into TheAlgorithms:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanglbme yanglbme yanglbme approved these changes

@siriak siriak siriak approved these changes

@debasishbsws debasishbsws debasishbsws left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@puneetripathi @debasishbsws @yanglbme @siriak