Skip to content

Created VolumeTest.java & Fixed Bugs in Volume.java #3682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 27, 2022

Conversation

TaranjeetSinghKalsi
Copy link
Contributor

@TaranjeetSinghKalsi TaranjeetSinghKalsi commented Oct 26, 2022

Created VolumeTest.java
And In Volume.java, Fixed Calculation error in volumeSphere() and volumeHemisphere() functions and removed main() and changed functions access specifier from private to public

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

Fixed calculation errors in volumeSphere() and volumeHemisphere() functions and removed main() and changed functions access specifier from private to public
Created VolumeTest.java JUnit Tests for Volume.java
Copy link
Member

@debasishbsws debasishbsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@debasishbsws debasishbsws enabled auto-merge (squash) October 27, 2022 14:10
@debasishbsws debasishbsws disabled auto-merge October 27, 2022 14:11
@debasishbsws debasishbsws merged commit 5ab1b6c into TheAlgorithms:master Oct 27, 2022
@TaranjeetSinghKalsi TaranjeetSinghKalsi deleted the patch-10 branch October 27, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants