Skip to content

Fibonacci optimized using binet's formula #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 30, 2022
Merged

Fibonacci optimized using binet's formula #3728

merged 6 commits into from
Oct 30, 2022

Conversation

Aayush2111
Copy link
Contributor

@Aayush2111 Aayush2111 commented Oct 28, 2022 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

debasishbsws
debasishbsws requested changes Oct 29, 2022
View reviewed changes
Copy link
Member

@debasishbsws debasishbsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I think as input became large output will not fit inside int anymore. think about it

@Aayush2111
Copy link
Contributor Author

Can you review again?
is it okay?

debasishbsws
debasishbsws approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@debasishbsws debasishbsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@debasishbsws debasishbsws merged commit 23eec39 into TheAlgorithms:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debasishbsws debasishbsws debasishbsws approved these changes

@siriak siriak Awaiting requested review from siriak siriak is a code owner

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aayush2111 @debasishbsws