-
Notifications
You must be signed in to change notification settings - Fork 20k
Added the String Compression Algorithm #3911 #3916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Swarga-codes
commented
Mar 9, 2023
- I have read CONTRIBUTING.md.
- This pull request is all my own work -- I have not plagiarized it.
- All filenames are in PascalCase.
- All functions and variable names follow Java naming conventions.
- All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove main
, add JUnit tests, remove excessive comments, and decompose compress
into smaller functions
Should I remove the main function from the code and make a test file in the test folder for this particular algorithm? |
@siriak I made the necessary changes as u told on the PR, the changes include: Reduce the size of code by dividing the code into smaller functions |
src/test/java/com/thealgorithms/strings/StringCompressionTest.java
Outdated
Show resolved
Hide resolved
I made the necessary changes as per your instructions, that is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!