adding of the combSort.java #403
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianbender
requested changes
Apr 4, 2018
Sorts/combSort.java
Outdated
| * | ||
| */ | ||
|
|
||
| public class combSort{ |
There was a problem hiding this comment.
Please respect naming conventions. Class names begin with upper case. Rename your file, too.
Sorts/combSort.java
Outdated
|
|
||
|
|
||
| public static <T extends Comparable<T>> void CS(T[] arr, int n) { | ||
| int intervalle = n; //initialisation of intervalle |
Sorts/combSort.java
Outdated
| boolean echange = true; //initialisation at true; | ||
|
|
||
| while(intervalle>1 || echange==true){ | ||
| intervalle =(int)(intervalle/1.3); |
There was a problem hiding this comment.
You can simple write intervalle /= 1.3;
Sorts/combSort.java
Outdated
| int intervalle = n; //initialisation of intervalle | ||
| boolean echange = true; //initialisation at true; | ||
|
|
||
| while(intervalle>1 || echange==true){ |
There was a problem hiding this comment.
Instead of echange==true you can write echange. Please write spaces between the operators.
Sorts/combSort.java
Outdated
|
|
||
| // Integer Input | ||
| int[] arr1 = {4,23,6,78,1,54,231,9,12}; | ||
| int n = arr1.length; |
There was a problem hiding this comment.
unnecessary. Use the length attribute of the array.
Sorts/combSort.java
Outdated
| **/ | ||
|
|
||
|
|
||
| public static <T extends Comparable<T>> void CS(T[] arr, int n) { |
There was a problem hiding this comment.
n is unnecessary. Use the length attribute of the array.
Sorts/combSort.java
Outdated
|
|
||
| // Output => 1 4 6 9 12 23 54 78 231 | ||
| for(int i=0; i<n; i++) | ||
| { |
There was a problem hiding this comment.
Please respect code style conventions for bracketing. see
Sorts/combSort.java
Outdated
| **/ | ||
|
|
||
|
|
||
| public static <T extends Comparable<T>> void CS(T[] arr, int n) { |
There was a problem hiding this comment.
Java methods begin with lower case.
Input : Source base , Source number , Destination base Output : Destination Number
modification of CombSort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add the algorithm of combSort.java in the Sort directory