Add TopKWords.java and fix one typos #406

0xkookoo · 2018-04-04T21:50:36Z

No description provided.

christianbender · 2018-04-08T17:58:19Z

Others/TopKWords.java

+/* display the most frequent K words in the file and the times it appear 
+    in the file – shown in order (ignore case and periods) */
+
+public   class  TopKWords {


Remove unnecessary spaces between public, class and the class name.

christianbender · 2018-04-08T18:00:48Z

Others/TopKWords.java

+            in = fis.read();  // read one character
+            boolean notEnd = true;  // signal whether is the end of file
+
+            while (notEnd) {


Write simple

while (in != -1) { }

christianbender · 2018-04-08T18:01:13Z

Others/TopKWords.java

+
+            while (notEnd) {
+                // when in == -1 means get the end of the file
+                if (-1 == in) {


See my comment above. You can avoid this if

christianbender · 2018-04-08T18:02:28Z

Others/TopKWords.java

+
+            fis = new FileInputStream(fileName);  // open the file
+            int in = 0;
+            StringBuffer sb = new StringBuffer();  // load the word


Instead of StringBuffer use String

christianbender · 2018-04-08T18:02:55Z

Others/TopKWords.java

+                    notEnd = false;  //if false, end the while loop
+                }
+                if (Character.isLetter((char)in)) {
+                    sb.append((char)in);  //if get a letter, put it in StringBuffer


Use String and the operator +=

christianbender · 2018-04-08T18:03:45Z

Others/TopKWords.java

+                    // this branch means an entire word has just been read
+                    if (sb.length() > 0) {
+                        //see whether word exists in StringBuffer or not
+                        if (dictionary.containsKey(sb.toString())) {


See my comments above. You can avoid .toString()

christianbender · 2018-04-08T18:04:19Z

Others/TopKWords.java

+                            dictionary.put(sb.toString(), 1);
+                        }
+                    }
+                    sb = new StringBuffer(); //reload the StringBuffer


Write instead sb = ""; . See my comments above.

christianbender · 2018-04-08T18:05:53Z

Others/TopKWords.java

+    }
+}
+
+class  CountWords {


Put this class in another file. Or Write it as inline class. Remove the unnecessary spaces between 'class' and 'CountWords'

christianbender · 2018-04-08T18:08:37Z

Others/TopKWords.java

+        );
+
+        Scanner input = new Scanner(System.in);
+        Integer k = new Integer(input.nextLine());


Instead of Integer k = new Integer(input.nextLine()); write int k = input.nextInt();

christianbender · 2018-04-08T18:09:05Z

Others/TopKWords.java

+        while (k > list.size()) {
+            System.out.println("Retype a number, your number is too large");
+            input = new Scanner(System.in);
+            k = new Integer(input.nextLine());


Read my comment above.

All has been improved according to your advice.

0xkookoo · 2018-04-08T22:05:09Z

All has been improved according to your advice, please check it.

christianbender

Good Work!

christianbender · 2018-04-09T13:22:03Z

Others/TopKWords.java

+
+                fis = new FileInputStream(fileName);  // open the file
+                int in = 0;
+                String s = new String();  // init a empty word


You don't need new String() you can simply write String s = "";

christianbender · 2018-04-09T13:23:11Z

Others/TopKWords.java

@@ -19,74 +70,15 @@ public static void main(String[] a) {
        );

        Scanner input = new Scanner(System.in);
-        Integer k = new Integer(input.nextLine());
+        int k = input.nextInt();
        while (k > list.size()) {
            System.out.println("Retype a number, your number is too large");
            input = new Scanner(System.in);
            k = new Integer(input.nextLine());


Change this line k = new Integer(input.nextLine());, too.

0xkookoo · 2018-04-09T14:17:19Z

Done. Also, I request to be a member of your team. I have sent an email for a couple of days but no reply.

christianbender · 2018-04-11T15:34:54Z

@Lisanaaa see In the description you will find two email-addresses. Sent your mail to them. greetings

0xkookoo · 2018-04-11T18:54:22Z

I have already sent to the first email address a couple days ago, should I sent both?

0xkookoo added 2 commits April 4, 2018 16:07

Update TreeTraversal.java

51be5a1

Create TopKWords.java

df1b68b

christianbender requested changes Apr 8, 2018

View reviewed changes

christianbender added the on hold label Apr 8, 2018

Update TopKWords.java

68d9450

All has been improved according to your advice.

christianbender requested changes Apr 9, 2018

View reviewed changes

Update TopKWords.java

0cf0aba

christianbender merged commit 43d3a56 into TheAlgorithms:master Apr 11, 2018

Add TopKWords.java and fix one typos #406

Add TopKWords.java and fix one typos #406

Uh oh!

Conversation

0xkookoo commented Apr 4, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xkookoo commented Apr 8, 2018

Uh oh!

christianbender left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xkookoo commented Apr 9, 2018

Uh oh!

christianbender commented Apr 11, 2018

Uh oh!

0xkookoo commented Apr 11, 2018

Uh oh!

Uh oh!