Skip to content

tests: add tests for EulersFunction #4216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 19, 2023
Merged

tests: add tests for EulersFunction #4216

merged 4 commits into from
Jun 19, 2023

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jun 19, 2023

This PR:

  • adds tests for EulersFunction,
  • updates EulersFunction.getEuler to throw an IllegalArgumentException for non-positive inputs,
  • makes EulersFunction a proper utility class,
  • updates the documentation.
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

siriak
siriak approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) June 19, 2023 17:46
@siriak siriak merged commit 87d6083 into TheAlgorithms:master Jun 19, 2023
@vil02 vil02 deleted the add_tests_euler_function branch June 19, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debasishbsws debasishbsws debasishbsws left review comments

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vil02 @siriak @debasishbsws