refactor: simplify HammingDistance
#4218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found few problems with the implementation of
HammingDistance
, namely:String
tobyte[]
,String
s containing only0
s and1
s, but this is not checked anywhere.This PR:
HammingDistance
in 610def7,1
in 58f7da3,HammingDistance
, updates naming and changes the behaviour for non-binary strings in 00d54bd,