Skip to content

surfaceAreaTriangle(fn_name_modified) #4220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2023
Merged

surfaceAreaTriangle(fn_name_modified) #4220

merged 3 commits into from
Jun 23, 2023

Conversation

THIRU-1074
Copy link
Contributor

---changing the function's identifier from surfaceAreaTriangleRectangle to surfaceAreaTriangle.

siriak
siriak requested changes Jun 23, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update tests

@THIRU-1074
Copy link
Contributor Author

Please also update tests

Yeah I have modified and commited.

@siriak
Copy link
Member

siriak commented Jun 23, 2023

Please see build logs, there are some errors Error: COMPILATION ERROR :
[INFO] -------------------------------------------------------------
Error: /home/runner/work/Java/Java/src/test/java/com/thealgorithms/maths/AreaTest.java:[39,32] cannot find symbol
symbol: method surfaceAreaTriangleRectangle(int,int)
location: class com.thealgorithms.maths.Area
Error: /home/runner/work/Java/Java/src/test/java/com/thealgorithms/maths/AreaTest.java:[84,75] cannot find symbol
symbol: method surfaceAreaTriangleRectangle(int,int)
location: class com.thealgorithms.maths.Area
Error: /home/runner/work/Java/Java/src/test/java/com/thealgorithms/maths/AreaTest.java:[86,75] cannot find symbol
symbol: method surfaceAreaTriangleRectangle(int,int)
location: class com.thealgorithms.maths.Area

@THIRU-1074
Copy link
Contributor Author

Please see build logs, there are some errors Error: COMPILATION ERROR : [INFO] ------------------------------------------------------------- Error: /home/runner/work/Java/Java/src/test/java/com/thealgorithms/maths/AreaTest.java:[39,32] cannot find symbol symbol: method surfaceAreaTriangleRectangle(int,int) location: class com.thealgorithms.maths.Area Error: /home/runner/work/Java/Java/src/test/java/com/thealgorithms/maths/AreaTest.java:[84,75] cannot find symbol symbol: method surfaceAreaTriangleRectangle(int,int) location: class com.thealgorithms.maths.Area Error: /home/runner/work/Java/Java/src/test/java/com/thealgorithms/maths/AreaTest.java:[86,75] cannot find symbol symbol: method surfaceAreaTriangleRectangle(int,int) location: class com.thealgorithms.maths.Area

Thank you ! Siriak for guiding me ...Now all the checks have passed.

siriak
siriak approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 05ca93e into TheAlgorithms:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@THIRU-1074 @siriak