Skip to content

feat: make SinglyLinkedList Iterable #4334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Aug 27, 2023

This PR makes the SinglyLinkedList an Iterable. Some of the methods were updated to use the enhanced for loop. This is a preparation to make PalindromeSinglyLinkedList.isPalindrome more efficient (cf. #4327).

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

@vil02 vil02 force-pushed the make_SinglyLinkedList_Iterable branch from 02cdeef to 86b540e Compare August 27, 2023 20:15
@vil02 vil02 marked this pull request as ready for review August 27, 2023 20:17
@siriak siriak enabled auto-merge (squash) August 28, 2023 07:08
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit ea15f2b into TheAlgorithms:master Aug 28, 2023
@vil02 vil02 deleted the make_SinglyLinkedList_Iterable branch August 28, 2023 16:54
@doxxx93
Copy link
Contributor

doxxx93 commented Sep 20, 2023

good! I think you resolved my issue.

maybe can you add this issue? #4326

@vil02
Copy link
Member Author

vil02 commented Sep 20, 2023

@doxxx93 it was an accident, I was working on another thing and this change seem to be natural. I hope you were not working on this in parallel.

Closes #4326

@doxxx93
Copy link
Contributor

doxxx93 commented Sep 22, 2023

yeah! no problem. Your implement looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants