add two sum problem #4364
Merged
add two sum problem #4364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9011ca4 to
4fb3e7d
Compare
Manan-09
reviewed
Sep 10, 2023
|
@siriak please check. |
vil02
requested changes
Sep 10, 2023
vil02
requested changes
Sep 10, 2023
There was a problem hiding this comment.
Sorry for a mammoth suggestion. Short summary:
- I suggest to use
Optional<Pair<Integer, Integer>>as a return type. Why? If the solution exists, the output should be two numbers. I suggest it to encode this information into the return type (int[]might be arbitrarily long), - I renamed
maptovalueToIndex. Maybe it is still not perfect, but stores some information what is the key and what is the value of this map, - renamed nums to values,
- adapted tests,
- added a new test, so that there is 100 % coverage.
vil02
approved these changes
Sep 12, 2023
|
@siriak check! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.