Skip to content

#4387 Enhance Minimum sum partition problem implementation #4394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 23, 2023
Merged

#4387 Enhance Minimum sum partition problem implementation #4394

merged 8 commits into from
Sep 23, 2023

Conversation

Manan-09
Copy link
Contributor

@Manan-09 Manan-09 commented Sep 21, 2023 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

Resolves 4387

Testcase cover 100% code

Screenshot 2023-09-22 at 2 50 15 AM

vil02
vil02 requested changes Sep 22, 2023
View reviewed changes
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to add the examples from the description to the test file.

Could you also update the description of the problem? At the moment is not very instructive.

Does it work for input array having negative numbers? This would need some explanation.

@Manan-09
Copy link
Contributor Author

@vil02 This implementation is for non-negative numbers only.

vil02
vil02 requested changes Sep 22, 2023
View reviewed changes
vil02
vil02 requested changes Sep 23, 2023
View reviewed changes
@vil02 vil02 merged commit 8803b1e into TheAlgorithms:master Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vil02 vil02 vil02 approved these changes

@siriak siriak Awaiting requested review from siriak siriak is a code owner

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat : Enhance Minimum sum partition
2 participants
@Manan-09 @vil02