Skip to content

Add FindMaxRecursionTest #4431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Oct 1, 2023
Merged

Add FindMaxRecursionTest #4431

merged 21 commits into from
Oct 1, 2023

Conversation

lukasb1b
Copy link
Contributor

@lukasb1b lukasb1b commented Sep 29, 2023 •
edited
Loading

Change so it has its own test and not the main methode

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.

@vil02 vil02 self-assigned this Sep 29, 2023
vil02
vil02 requested changes Sep 29, 2023
View reviewed changes
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the FindMaxRecursion a proper utility class (i.e. marked as final with private default constructor).

Idea for future project: make all of the FindMax (and FindMin) like functions more uniform (i.e. same method names, same tests. etc.)

@lukasb1b
Copy link
Contributor Author

I changed the requests and even the max function

@vil02
Copy link
Member

vil02 commented Sep 30, 2023

As mentioned earlier please add private default constructor.

vil02
vil02 requested changes Sep 30, 2023
View reviewed changes
@lukasb1b @vil02
Update src/main/java/com/thealgorithms/maths/FindMaxRecursion.java
6fe8a0f 
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
@vil02 vil02 changed the title Find max recusion test Add FindMaxRecursionTest Oct 1, 2023
vil02
vil02 approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@vil02 vil02 enabled auto-merge (squash) October 1, 2023 14:47
@vil02 vil02 disabled auto-merge October 1, 2023 14:50
@vil02 vil02 enabled auto-merge (squash) October 1, 2023 14:50
@vil02
Copy link
Member

vil02 commented Oct 1, 2023

@lukasb1b In order to merge this you need to update your branch (I do not have a permission to commit anything to your branch, so I cannot do it).

@vil02 vil02 merged commit 8dc5505 into TheAlgorithms:master Oct 1, 2023
@lukasb1b lukasb1b deleted the FindMaxRecusionTest branch October 1, 2023 18:22
@lukasb1b lukasb1b mentioned this pull request Oct 2, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vil02 vil02 vil02 approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

Assignees

@vil02 vil02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasb1b @vil02