Skip to content

Greedy Algorithm Implementations and Explanations #4493 #4504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Oct 3, 2023
Merged

Greedy Algorithm Implementations and Explanations #4493 #4504

merged 25 commits into from
Oct 3, 2023

Conversation

Vineetttt
Copy link
Contributor

@Vineetttt Vineetttt commented Oct 1, 2023 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

siriak
siriak requested changes Oct 1, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, could you please remove main, logging to console, and add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)

@Vineetttt Vineetttt requested a review from siriak October 1, 2023 22:14
Vineetttt
Vineetttt commented Oct 2, 2023
View reviewed changes
Copy link
Contributor Author

@Vineetttt Vineetttt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the necessary changes you can check and merge accordingly.

siriak
siriak requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix PR checks

Vineetttt
Vineetttt commented Oct 2, 2023
View reviewed changes
Copy link
Contributor Author

@Vineetttt Vineetttt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appropriate changes are made, can you check.

@Vineetttt Vineetttt requested a review from siriak October 2, 2023 11:28
@siriak
Copy link
Member

siriak commented Oct 2, 2023

Please fix the linter job which is failing and add more tests for coin change

@Vineetttt
Copy link
Contributor Author

@siriak Necessary changes are made, you can check .

siriak
siriak requested changes Oct 3, 2023
View reviewed changes
@siriak siriak enabled auto-merge (squash) October 3, 2023 17:28
@siriak siriak disabled auto-merge October 3, 2023 17:28
@siriak siriak merged commit 535230a into TheAlgorithms:master Oct 3, 2023
SanketPatil7467 added a commit to SanketPatil7467/Java that referenced this pull request Oct 4, 2023
@SanketPatil7467
Revert "Add Greedy Algorithms (fixes TheAlgorithms#4493) (TheAlgorith…
a4daf07 
…ms#4504)"

This reverts commit 535230a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@vil02 vil02 Awaiting requested review from vil02 vil02 is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vineetttt @siriak