Skip to content

code-clean-up #4519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 3, 2023
Merged

code-clean-up #4519

merged 4 commits into from
Oct 3, 2023

Conversation

asapekia
Copy link
Contributor

@asapekia asapekia commented Oct 1, 2023

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

@asapekia
Copy link
Contributor Author

asapekia commented Oct 2, 2023

@vil02 please review.

vil02
vil02 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a update of existing code it looks good. Clearly the search method still needs some work. Maybe you would like to break it into smaller pieces?

@TheAlgorithms TheAlgorithms deleted a comment from Rxrabi Oct 3, 2023
@vil02 vil02 enabled auto-merge (squash) October 3, 2023 17:31
@vil02 vil02 merged commit 4fab7ad into TheAlgorithms:master Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vil02 vil02 vil02 approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asapekia @vil02 @arintripathi1