Skip to content

Made changes to the code to correct the Logic of Armstrong Number #4619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Made changes to the code to correct the Logic of Armstrong Number #4619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b35d949
Made changes to the code to correct the Logic of Armstrong Number
satyabarghav Oct 4, 2023
971b80a
Resolved the issues
satyabarghav Oct 4, 2023
de325cb
Trying to resolve the Linter error by changing Variable name
satyabarghav Oct 4, 2023
6f64e8c
Changed Variable Names : trying to resolve Clang error
satyabarghav Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 20 additions & 13 deletions src/main/java/com/thealgorithms/maths/Armstrong.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,36 @@
package com.thealgorithms.maths;

/**
* An Armstrong number is equal to the sum of the cubes of its digits. For
* example, 370 is an Armstrong number because 3*3*3 + 7*7*7 + 0*0*0 = 370. An
* Armstrong number is often called Narcissistic number.
* This class checks whether a given number is an Armstrong number or not.
* An Armstrong number is a number that is equal to the sum of its own digits,
* each raised to the power of the number of digits.
*
* @author Vivek
* For example, 370 is an Armstrong number because 3^3 + 7^3 + 0^3 = 370.
* 1634 is an Armstrong number because 1^4 + 6^4 + 3^4 + 4^4 = 1634.
* An Armstrong number is often called a Narcissistic number.
*
* @author satyabarghav
*/
public class Armstrong {

/**
* Checks whether a given number is an armstrong number or not.
* Checks whether a given number is an Armstrong number or not.
*
* @param number number to check
* @return {@code true} if given number is armstrong number, {@code false}
* otherwise
* @param number the number to check
* @return {@code true} if the given number is an Armstrong number, {@code false} otherwise
*/
public boolean isArmstrong(int number) {
long sum = 0;
long number2 = number;
while (number2 > 0) {
long mod = number2 % 10;
sum += Math.pow(mod, 3);
number2 /= 10;
String temp = Integer.toString(number); // Convert the given number to a string
int power = temp.length(); // Extract the length of the number (number of digits)
long originalNumber = number;

while (originalNumber > 0) {
long digit = originalNumber % 10;
sum += Math.pow(digit, power); // The digit raised to the power of the number of digits and added to the sum.
originalNumber /= 10;
}

return sum == number;
}
}
8 changes: 5 additions & 3 deletions src/test/java/com/thealgorithms/maths/ArmstrongTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
import org.junit.jupiter.api.Test;

/**
* @author Vivek
* @since 15/03/22
* @author satyabarghav
* @since 4/10/2023
*/
class ArmstrongTest {

Expand All @@ -17,7 +17,9 @@ void testIsArmstrong() {
assertThat(armstrong.isArmstrong(1)).isTrue();
assertThat(armstrong.isArmstrong(153)).isTrue();
assertThat(armstrong.isArmstrong(371)).isTrue();
assertThat(armstrong.isArmstrong(1634)).isFalse();
assertThat(armstrong.isArmstrong(1634)).isTrue();
assertThat(armstrong.isArmstrong(200)).isFalse();
assertThat(armstrong.isArmstrong(548834)).isTrue();
assertThat(armstrong.isArmstrong(9474)).isTrue();
}
}