Skip to content

fixed bug in method gcd(int, int) #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2018
Merged

fixed bug in method gcd(int, int) #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 30 additions & 22 deletions Others/GCD.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,37 @@
//This is Euclid's algorithm which is used to find the greatest common denominator
//Overide function name gcd

public class GCD{

public static int gcd(int num1, int num2) {

int gcdValue = num1 % num2;
while (gcdValue != 0) {
num2 = gcdValue;
gcdValue = num2 % gcdValue;
public class GCD {

public static int gcd(int num1, int num2) {

if (num1 == 0)
return num2;

while (num2 != 0) {
if (num1 > num2)
num1 -= num2;
else
num2 -= num1;
}
return num2;

return num1;
}
public static int gcd(int[] number) {
int result = number[0];
for(int i = 1; i < number.length; i++)
//call gcd function (input two value)
result = gcd(result, number[i]);

return result;
}

public static void main(String[] args) {
int[] myIntArray = {4,16,32};
//call gcd function (input array)
System.out.println(gcd(myIntArray));

public static int gcd(int[] number) {
int result = number[0];
for (int i = 1; i < number.length; i++)
// call gcd function (input two value)
result = gcd(result, number[i]);

return result;
}

public static void main(String[] args) {
int[] myIntArray = { 4, 16, 32 };

// call gcd function (input array)
System.out.println(gcd(myIntArray)); // => 4
System.out.printf("gcd(40,24)=%d gcd(24,40)=%d\n", gcd(40, 24), gcd(24, 40)); // => 8
}
}