Skip to content

Cleanup BoyerMoore #4951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 31, 2023
Merged

Cleanup BoyerMoore #4951

merged 14 commits into from
Oct 31, 2023

Conversation

prathameshpowar1910
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@prathameshpowar1910 prathameshpowar1910 mentioned this pull request Oct 31, 2023
Closed
vil02
vil02 requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@vil02 vil02 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the findmajor method as described in the issue. I think it is also worth to rename it to findMajor.

I have pushed one commit into your branch: fe687c3. The Most important change is to

return Optional.of(cand);

Besides that I have adapted the tests.

This PR closes #4949.

@vil02 vil02 changed the title Boyer-moore-patch-1 Cleanup BoyerMoore Oct 31, 2023
@vil02 vil02 self-assigned this Oct 31, 2023
vil02
vil02 requested changes Oct 31, 2023
View reviewed changes
@vil02 vil02 merged commit 574138c into TheAlgorithms:master Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vil02 vil02 vil02 approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

Assignees

@vil02 vil02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prathameshpowar1910 @vil02