Skip to content

Fixed wrong compare() method for subset check (S.A ⊆ T.A) #4978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 7, 2023
Merged

Fixed wrong compare() method for subset check (S.A ⊆ T.A) #4978

merged 4 commits into from
Dec 7, 2023

Conversation

itakurah
Copy link
Contributor

@itakurah itakurah commented Dec 7, 2023

Fixed bug in the compare() method where the subet check is not performed on the actual object.

from:

    public boolean compare(GSet<T> other) {
        return elements.containsAll(other.elements);
    }

to:

    public boolean compare(GSet<T> other) {
        return other.elements.containsAll(elements);
    }

See:
compare (S, T) : boolean b
let b = (S.A ⊆ T.A)

https://en.wikipedia.org/wiki/Conflict-free_replicated_data_type

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@itakurah itakurah marked this pull request as ready for review December 7, 2023 12:49
@siriak siriak merged commit 92131de into TheAlgorithms:master Dec 7, 2023
@siriak
Copy link
Member

siriak commented Dec 7, 2023

Thanks!

@itakurah itakurah deleted the gsetfix branch December 8, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@vil02 vil02 Awaiting requested review from vil02

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itakurah @siriak