Skip to content

Updated TwoPSet to use Generics instead of Strings #4981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 11, 2023
Merged

Updated TwoPSet to use Generics instead of Strings #4981

merged 4 commits into from
Dec 11, 2023

Conversation

itakurah
Copy link
Contributor

This PR updates the TwoPSet.java and TwoPSetTest.java to use Generics TwoPSet<T> instead of TwoPSet<String> to make the class more flexible and to allow the use of custom objects with TwoPSet.

public class TwoPSet<T> {
    private final Set<T> setA;
    private final Set<T> setR;
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@itakurah itakurah marked this pull request as ready for review December 11, 2023 10:09
siriak
siriak approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 4aa8e6a into TheAlgorithms:master Dec 11, 2023
@itakurah itakurah deleted the 2psetpatch branch December 15, 2023 12:09
@555vedant 555vedant mentioned this pull request Jan 6, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@vil02 vil02 Awaiting requested review from vil02 vil02 is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itakurah @siriak