Skip to content

Cleanup SumOfDigits and its tests #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2024
Merged

Cleanup SumOfDigits and its tests #4994

merged 1 commit into from
Jan 5, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jan 4, 2024 •
edited
Loading

This PR is a pretty straightforward cleanup of the SumOfDigits, namely it:

  • uses Math.abs,
  • makes sumOfDigitsFast more functional,
  • rewrites tests as parameterized test.
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@vil02 vil02 marked this pull request as ready for review January 4, 2024 15:54
siriak
siriak approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 8930ab5 into TheAlgorithms:master Jan 5, 2024
@vil02 vil02 deleted the cleanup_sum_of_digits branch January 5, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vil02 @siriak