Skip to content

CountSetBits algorithm added #5054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

CountSetBits algorithm added #5054

wants to merge 5 commits into from

Conversation

pankaj-bind
Copy link

@pankaj-bind pankaj-bind commented Mar 1, 2024 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@BamaCharanChhandogi
Copy link
Member

https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/others/countSetBits.java
Duplicate

@pankaj-bind
Copy link
Author

But I haven't seen anyone similar to this.

@vil02
Copy link
Member

vil02 commented Mar 1, 2024

As pointed out by @BamaCharanChhandogi countSetBits already exists. But it needs some cleanup:

@pankaj-bind would you like to open a new PR with changes decried above?

@vil02 vil02 closed this Mar 1, 2024
@pankaj-bind
Copy link
Author

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@vil02 vil02 Awaiting requested review from vil02 vil02 is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pankaj-bind @BamaCharanChhandogi @vil02