refactor: cleanup CycleSort
#5271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5271 +/- ##
============================================
+ Coverage 40.50% 40.66% +0.16%
- Complexity 2494 2503 +9
============================================
Files 519 519
Lines 15470 15447 -23
Branches 2950 2949 -1
============================================
+ Hits 6266 6282 +16
+ Misses 8915 8870 -45
- Partials 289 295 +6 ☔ View full report in Codecov by Sentry. |
BamaCharanChhandogi
requested changes
Jul 4, 2024
Thank you. I've been eager to enhance test coverage for sorting algorithms for quite some time. |
|
Hello, @BamaCharanChhandogi everything fixed now |
BamaCharanChhandogi
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup CycleSort. Adding test for it. Simplify code.
clang-format -i --style=file path/to/your/file.java