Skip to content

Enhance comments & improve readability in LongestCommonSubsequence.java #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 5, 2024
Merged

Enhance comments & improve readability in LongestCommonSubsequence.java #5523

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
df30da1
Enhance comments & improve readability in LongestCommonSubsequence.java
Hardvan Oct 2, 2024
cacb821
Merge branch 'master' into lcs_improvement
Hardvan Oct 4, 2024
ad63b6e
Update directory
Hardvan Oct 4, 2024
22c2100
Remove main method
Hardvan Oct 4, 2024
f7fd7f1
Add tests
Hardvan Oct 4, 2024
2cfb485
Merge branch 'lcs_improvement' of https://github.com/Hardvan/Java int…
Hardvan Oct 4, 2024
9c1ff5a
Update directory
Hardvan Oct 4, 2024
51833e0
Fix comment
Hardvan Oct 4, 2024
2e922d0
Merge branch 'lcs_improvement' of https://github.com/Hardvan/Java int…
Hardvan Oct 4, 2024
aa5c5f1
Fix test
Hardvan Oct 4, 2024
28e82e4
Merge branch 'master' into lcs_improvement
siriak Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests
  • Loading branch information
@Hardvan
Hardvan committed Oct 4, 2024
commit f7fd7f1187d62c037ab66dd75506e93bc0acb92f
89 changes: 89 additions & 0 deletions src/test/java/com/thealgorithms/dynamicprogramming/LongestCommonSubsequenceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
package com.thealgorithms.dynamicprogramming;

import static org.junit.jupiter.api.Assertions.assertEquals;

import org.junit.jupiter.api.Test;

public class LongestCommonSubsequenceTest {

@Test
public void testLCSBasic() {
String str1 = "ABCBDAB";
String str2 = "BDCAB";
String expected = "BDAB"; // The longest common subsequence
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}

@Test
public void testLCSIdenticalStrings() {
String str1 = "AGGTAB";
String str2 = "AGGTAB";
String expected = "AGGTAB"; // LCS is the same as the strings
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}

@Test
public void testLCSNoCommonCharacters() {
String str1 = "ABC";
String str2 = "XYZ";
String expected = ""; // No common subsequence
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}

@Test
public void testLCSWithEmptyString() {
String str1 = "";
String str2 = "XYZ";
String expected = ""; // LCS with an empty string should be empty
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}

@Test
public void testLCSWithBothEmptyStrings() {
String str1 = "";
String str2 = "";
String expected = ""; // LCS with both strings empty should be empty
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}

@Test
public void testLCSWithNullFirstString() {
String str1 = null;
String str2 = "XYZ";
String expected = null; // Should return null if first string is null
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}

@Test
public void testLCSWithNullSecondString() {
String str1 = "ABC";
String str2 = null;
String expected = null; // Should return null if second string is null
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}

@Test
public void testLCSWithNullBothStrings() {
String str1 = null;
String str2 = null;
String expected = null; // Should return null if both strings are null
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}

@Test
public void testLCSWithLongerStringContainingCommonSubsequence() {
String str1 = "ABCDEF";
String str2 = "AEBDF";
String expected = "ABD"; // Common subsequence is "ABD"
String result = LongestCommonSubsequence.getLCS(str1, str2);
assertEquals(expected, result);
}
}