Skip to content

added graph algorithm #5825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 23, 2024
Merged

added graph algorithm #5825

merged 15 commits into from
Oct 23, 2024

Conversation

vickygit-commits
Copy link
Contributor

@vickygit-commits vickygit-commits commented Oct 14, 2024 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.18%. Comparing base (6006025) to head (ffebf65).
Report is 91 commits behind head on master.

Files with missing lines Patch % Lines
...hms/graph/StronglyConnectedComponentOptimized.java 93.18% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5825      +/-   ##
============================================
+ Coverage     67.10%   67.18%   +0.07%     
- Complexity     4560     4561       +1     
============================================
  Files           619      620       +1     
  Lines         17098    17142      +44     
  Branches       3296     3310      +14     
============================================
+ Hits          11474    11517      +43     
+ Misses         5168     5167       -1     
- Partials        456      458       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vickygit-commits
Copy link
Contributor Author

vickygit-commits commented Oct 14, 2024 •
edited
Loading

I have done with JUnit tests and all Prechecks. Is there anything further needed??

@vickygit-commits
Copy link
Contributor Author

Can anyone review this branch???

siriak
siriak approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 23, 2024 05:41
@siriak siriak merged commit 2f9f75a into TheAlgorithms:master Oct 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@vil02 vil02 Awaiting requested review from vil02 vil02 is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vickygit-commits @codecov-commenter @siriak