Skip to content

Improvement: Removed main function from GCD class . Corrected and improved docstring. #5828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Tanmay-Singh3004
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

…ead of array as parameter for better user interaction, added one more test for Unit testing the varArgs function, improved the docstring
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.97%. Comparing base (ef72b1e) to head (da2feb4).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5828      +/-   ##
============================================
- Coverage     66.97%   66.97%   -0.01%     
+ Complexity     4522     4520       -2     
============================================
  Files           613      613              
  Lines         16989    16985       -4     
  Branches       3281     3281              
============================================
- Hits          11378    11375       -3     
+ Misses         5163     5160       -3     
- Partials        448      450       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tanmay-Singh3004 Tanmay-Singh3004 marked this pull request as ready for review October 14, 2024 19:08
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 22, 2024 17:52
@siriak siriak merged commit 0bb22fb into TheAlgorithms:master Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants