Skip to content

style: do not suppress lossy-conversions #6206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Mar 31, 2025

This PR includes lossy-conversions into the active compiler warnings.

Continuation of #5165.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@vil02 vil02 marked this pull request as draft March 31, 2025 16:16
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.74%. Comparing base (4514887) to head (7d55e30).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6206      +/-   ##
============================================
- Coverage     73.75%   73.74%   -0.01%     
- Complexity     5273     5275       +2     
============================================
  Files           669      669              
  Lines         18282    18283       +1     
  Branches       3528     3528              
============================================
  Hits          13483    13483              
- Misses         4258     4259       +1     
  Partials        541      541              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vil02 vil02 marked this pull request as ready for review March 31, 2025 16:19
@alxkm alxkm merged commit 0072ed9 into TheAlgorithms:master Mar 31, 2025
6 checks passed
@vil02 vil02 deleted the enable_lossy-conversions branch April 1, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants