Skip to content

Randomized closest 2 points algorithm #6251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Randomized closest 2 points algorithm #6251

wants to merge 13 commits into from

Conversation

bri-harris
Copy link

  • [x ] I have read CONTRIBUTING.md.
  • [ x] This pull request is all my own work -- I have not plagiarized it.
  • [ x] All filenames are in PascalCase.
  • [ x] All functions and variable names follow Java naming conventions.
  • [ x] All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • [ x] All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.02%. Comparing base (2320b46) to head (3150056).

Files with missing lines Patch % Lines
...java/com/thealgorithms/randomized/ClosestPair.java 91.89% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6251      +/-   ##
============================================
+ Coverage     73.98%   74.02%   +0.03%     
- Complexity     5346     5361      +15     
============================================
  Files           677      678       +1     
  Lines         18652    18689      +37     
  Branches       3621     3628       +7     
============================================
+ Hits          13800    13834      +34     
- Misses         4294     4296       +2     
- Partials        558      559       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@siriak
Copy link
Member

siriak commented Jun 1, 2025

@DenizAltunkapan could you take a look at infer?

@DenizAltunkapan
Copy link
Collaborator

@DenizAltunkapan could you take a look at infer?

Of course @siriak . I'll take a look, when i find time

@DenizAltunkapan
Copy link
Collaborator

The current build of facebook/infer is failing (see), which also causes our GitHub Actions workflow to fail. To temporarily stabilize our CI pipeline, I used the last known working commit. Once the upstream build is fixed, I will update our workflow to use the latest version again. I will open a new Pullrequest, when it's working again. 😄 @siriak @bri-harris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenizAltunkapan DenizAltunkapan Awaiting requested review from DenizAltunkapan DenizAltunkapan is a code owner

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@vil02 vil02 Awaiting requested review from vil02 vil02 is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner

@siriak siriak Awaiting requested review from siriak siriak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bri-harris @codecov-commenter @siriak @DenizAltunkapan